[SPARK-23044] Error handling for jira assignment

[squito]

What changes were proposed in this pull request?

• If there is any error while trying to assign the jira, prompt again
• Filter out the "Apache Spark" choice
• allow arbitrary user ids to be entered

How was this patch tested?

Couldn't really test the error case, just some testing of similar-ish code in python shell. Haven't run a merge yet.

[squito]

@jerryshao this should fix it, but I don't have anything to merge to test this out -- would appreciate if someone could try it before we merge.

[srowen]

Yeah, that's about all we can do here. I'm not sure if there's an API for the /roles screen, and adding the user as a contributor, but it's rare enough that it's OK to handle manually.

[vanzin]

Since you're here, would you like to try at add SPARK-23031 to this change?

[SparkQA]

Test build #85973 has finished for PR 20236 at commit 8c4cc61.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[squito]

@vanzin what exactly are you looking for? The one thing which would be easy is letting you write in an arbitrary jira id (no name searching or anything), that sound OK?

I guess this bug isn't really a major issue so no urgency in getting this in, so I can add to this

[vanzin]

Yeah, arbitrary name is fine. I tried it yesterday and the script just yelled at me because it was not an integer. (Filtering out "Apache Spark" is bonus.)

[jerryshao]

@squito thanks for the fix. I also don't have PRs to verify the changes, but I think catching exception should be enough.

[SparkQA]

Test build #86185 has finished for PR 20236 at commit 4d40b97.

• This patch fails Python style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #86186 has finished for PR 20236 at commit 7151cf0.

• This patch fails Python style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[squito]

@vanzin @jerryshao want to take another look?

Now it

• filters out "apache spark"
• lets you enter an arbitrary id
• if there's an error, just prompts again

sample session: https://gist.github.com/squito/de73fbd0b9c00961377068b91283e04c

[vanzin]

Looks good but you have some style check failures.

[vanzin]

it's

[SparkQA]

Test build #86194 has finished for PR 20236 at commit 4ab1202.

• This patch fails Python style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #86197 has finished for PR 20236 at commit 626dd47.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

Merging to master.