[SPARK-22551][SQL] Prevent possible 64kb compile error for common expression types#19780
Closed
viirya wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-22551][SQL] Prevent possible 64kb compile error for common expression types#19780viirya wants to merge 3 commits intoapache:masterfrom
viirya wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #83987 has finished for PR 19780 at commit
|
|
Test build #83988 has finished for PR 19780 at commit
|
Member
Author
|
cc @cloud-fan @kiszk |
Member
|
Could you add a test case? |
Member
Author
|
Test build #84000 has finished for PR 19780 at commit
|
|
Test build #84008 has finished for PR 19780 at commit
|
|
Test build #84009 has finished for PR 19780 at commit
|
Member
Author
|
I can't reproduce the issue after #19767 is merged. Hopefully it solves this issue too, so I will close this. If not and I can reproduce it later, I will re-open this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For common expression types, such as BinaryExpression and TernaryExpression, the combination of generated codes of children can possibly be large. We should put the codes into functions to prevent possible 64kb compile error.
How was this patch tested?
Added test.