[MINOR][CORE] Add missing kvstore module in Laucher and SparkSubmit code #19014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I35109bca61f9c0a246b7a9842a98947bc580c6dd
|
CC @vanzin , please help to review, thanks! |
|
Test build #80953 has finished for PR 19014 at commit
|
| @@ -988,7 +988,7 @@ private[spark] object SparkSubmitUtils { | |||
| // We need to specify each component explicitly, otherwise we miss spark-streaming-kafka-0-8 and | |||
| // other spark-streaming utility components. Underscore is there to differentiate between | |||
| // spark-streaming_2.1x and spark-streaming-kafka-0-8-assembly_2.1x | |||
| val IVY_DEFAULT_EXCLUDES = Seq("catalyst_", "core_", "graphx_", "launcher_", "mllib_", | |||
| val IVY_DEFAULT_EXCLUDES = Seq("catalyst_", "core_", "graphx_", "kvstore_", "launcher_", "mllib_", | |||
There was a problem hiding this comment.
+1, Thank you for keeping this up-to-date, @jerryshao !
cc @brkyvz
|
I had the launcher change in another PR, but missed the SparkSubmit one. LGTM. Merging to master (and will add SPARK-20641 to the commit summary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're two code in Launcher and SparkSubmit will will explicitly list all the Spark submodules, newly added kvstore module is missing in this two parts, so submitting a minor PR to fix this.