-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[Web UI]Make decision order of Worker's WebUI port consistent with Master's #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
add to whitelist |
LGTM if the tests pass. I guess we just never verified the order because no one was ever able to use the system properties to set the port until recently (a646a36) |
QA tests have started for PR 1838. This patch merges cleanly. |
QA results for PR 1838: |
Sorry for my carelessness. Now I fixed it. |
QA tests have started for PR 1838. This patch merges cleanly. |
QA tests have started for PR 1838. This patch DID NOT merge cleanly! |
QA tests have started for PR 1838. This patch merges cleanly. |
QA results for PR 1838: |
QA results for PR 1838: |
QA results for PR 1838: |
LGTM |
Could someone merge this? Thanks. @rxin |
Thanks. I'm merging this in master. |
…ster's The decision order of Worker's WebUI port is "--webui-port", SPARK_WORKER_WEBUI_POR, 8081(default), spark.worker.ui.port. But in Master, the order is "--webui-port", spark.master.ui.port, SPARK_MASTER_WEBUI_PORT and 8080(default). So we change the order in Worker's to keep it consistent with Master. Author: WangTao <barneystinson@aliyun.com> Closes apache#1838 from WangTaoTheTonic/reOrder and squashes the following commits: 460f4d4 [WangTao] Make decision order of Worker's WebUI consistent with Master's
The decision order of Worker's WebUI port is "--webui-port", SPARK_WORKER_WEBUI_POR, 8081(default), spark.worker.ui.port. But in Master, the order is "--webui-port", spark.master.ui.port, SPARK_MASTER_WEBUI_PORT and 8080(default).
So we change the order in Worker's to keep it consistent with Master.