Skip to content

[Web UI]Make decision order of Worker's WebUI port consistent with Master's #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WangTaoTheTonic
Copy link
Contributor

The decision order of Worker's WebUI port is "--webui-port", SPARK_WORKER_WEBUI_POR, 8081(default), spark.worker.ui.port. But in Master, the order is "--webui-port", spark.master.ui.port, SPARK_MASTER_WEBUI_PORT and 8080(default).

So we change the order in Worker's to keep it consistent with Master.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

add to whitelist

@andrewor14
Copy link
Contributor

LGTM if the tests pass. I guess we just never verified the order because no one was ever able to use the system properties to set the port until recently (a646a36)

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1838. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18127/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1838:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18127/consoleFull

@WangTaoTheTonic
Copy link
Contributor Author

Sorry for my carelessness. Now I fixed it.

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1838. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18130/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1838. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18131/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA tests have started for PR 1838. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18132/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1838:
- This patch PASSES unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18131/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1838:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18132/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 7, 2014

QA results for PR 1838:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18130/consoleFull

@andrewor14
Copy link
Contributor

LGTM

@WangTaoTheTonic
Copy link
Contributor Author

Could someone merge this? Thanks. @rxin

@rxin
Copy link
Contributor

rxin commented Aug 9, 2014

Thanks. I'm merging this in master.

@asfgit asfgit closed this in 1c84dba Aug 9, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…ster's

The decision order of Worker's WebUI port is "--webui-port", SPARK_WORKER_WEBUI_POR, 8081(default), spark.worker.ui.port. But in Master, the order is "--webui-port", spark.master.ui.port, SPARK_MASTER_WEBUI_PORT and 8080(default).

So we change the order in Worker's to keep it consistent with Master.

Author: WangTao <barneystinson@aliyun.com>

Closes apache#1838 from WangTaoTheTonic/reOrder and squashes the following commits:

460f4d4 [WangTao] Make decision order of Worker's WebUI consistent with Master's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants