[SPARK-21091][SQL] Move constraint code into QueryPlanConstraints#18298
Closed
rxin wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-21091][SQL] Move constraint code into QueryPlanConstraints#18298rxin wants to merge 3 commits intoapache:masterfrom
rxin wants to merge 3 commits intoapache:masterfrom
Conversation
rxin
commented
Jun 14, 2017
| private lazy val aliasMap: AttributeMap[Expression] = AttributeMap( | ||
| expressions.collect { | ||
| case a: Alias => (a.toAttribute, a.child) | ||
| } ++ children.flatMap(_.asInstanceOf[QueryPlanConstraints[PlanType]].aliasMap)) |
Contributor
Author
There was a problem hiding this comment.
this is the only weird part; the rest are straightforward copy.
I couldn't figure out how to get the compiler to past without the explicit cast.
Contributor
There was a problem hiding this comment.
what if we do trait QueryPlanConstraints[PlanType <: QueryPlan[PlanType]] extends QueryPlan[PlanType]?
Contributor
Author
There was a problem hiding this comment.
that would create a cyclic hierarchy ...
|
Test build #78034 has started for PR 18298 at commit |
|
Test build #78039 has finished for PR 18298 at commit
|
|
Test build #3797 has finished for PR 18298 at commit
|
Member
|
retest this please |
Member
|
LGTM |
|
Test build #78061 has finished for PR 18298 at commit
|
gatorsmile
reviewed
Jun 14, 2017
| lazy val constraints: ExpressionSet = | ||
| ExpressionSet( | ||
| validConstraints | ||
| .union(inferAdditionalConstraints(constraints)) |
gatorsmile
reviewed
Jun 14, 2017
| ExpressionSet( | ||
| validConstraints | ||
| .union(inferAdditionalConstraints(constraints)) | ||
| .union(constructIsNotNullConstraints(constraints)) |
Member
|
Thanks for the cleanup! LGTM modulo Xiao's comment. |
This reverts commit a212b14.
Member
|
LGTM |
Contributor
Author
|
Merging in master. |
|
Test build #78067 has finished for PR 18298 at commit
|
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? This patch moves constraint related code into a separate trait QueryPlanConstraints, so we don't litter QueryPlan with a lot of constraint private functions. ## How was this patch tested? This is a simple move refactoring and should be covered by existing tests. Author: Reynold Xin <rxin@databricks.com> Closes apache#18298 from rxin/SPARK-21091.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch moves constraint related code into a separate trait QueryPlanConstraints, so we don't litter QueryPlan with a lot of constraint private functions.
How was this patch tested?
This is a simple move refactoring and should be covered by existing tests.