[SPARK-2896] Remove redundant error notification by results.put() when fetching from remote #1823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| * because when iterator get FetchResult which size is -1, | ||
| * FetchFailedException is thrown immediately. | ||
| */ | ||
| results.put(new FetchResult(req.blocks(0)._1, -1, null)) |
There was a problem hiding this comment.
Changing this seems somewhat brittle... what if we want to change the behavior on the receiving end? These results are very small, I don't see a big problem with sending them.
|
I took a quick look - I'm not sure we want to change this. Just because only the first result is used right now doesn't mean we won't want to do something more sophisticated in the future. And donwstream consumers of code could make the assumption that all failed fetches will be present. |
|
Do you mind closing this? This whole code is going to be updated by #2330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.