[SPARK-2887] fix bug of countApproxDistinct() when have more than one partition #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mateiz |
|
Hah, pretty crazy! Glad you caught that. |
|
Jenkins, add to whitelist and test this please |
|
Jenkins, test this please. |
|
QA tests have started for PR 1812. This patch merges cleanly. |
|
QA results for PR 1812: |
|
Thanks, going to merge this. |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2014
… partition fix bug of countApproxDistinct() when have more than one partition Author: Davies Liu <davies.liu@gmail.com> Closes #1812 from davies/approx and squashes the following commits: bf757ce [Davies Liu] fix bug of countApproxDistinct() when have more than one partition (cherry picked from commit ffd1f59) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
|
Merged into master and 1.1. @davies mind submitting a PR for 1.0 and 0.9? This doesn't merge cleanly into those ATM. |
| @@ -1004,7 +1004,7 @@ abstract class RDD[T: ClassTag]( | |||
| }, | |||
| (h1: HyperLogLogPlus, h2: HyperLogLogPlus) => { | |||
| h1.addAll(h2) | |||
| h2 | |||
| h1 | |||
There was a problem hiding this comment.
ah can't believe I missed that
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
… partition fix bug of countApproxDistinct() when have more than one partition Author: Davies Liu <davies.liu@gmail.com> Closes apache#1812 from davies/approx and squashes the following commits: bf757ce [Davies Liu] fix bug of countApproxDistinct() when have more than one partition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug of countApproxDistinct() when have more than one partition