Skip to content

[HOTFIX][Streaming] Handle port collisions in flume polling test #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[HOTFIX][Streaming] Handle port collisions in flume polling test #1803

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af3ddc9
Handle port collisions in flume polling test
andrewor14 Aug 6, 2014
664095c
Tone down bind exception message
andrewor14 Aug 6, 2014
54a0ca0
Merge branch 'master' of github.com:apache/spark into fix-flaky-strea…
andrewor14 Aug 6, 2014
ea11a03
Catch all exceptions caused by BindExceptions
andrewor14 Aug 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion external/flume/src/test/scala/org/apache/spark/streaming/flume/FlumePollingStreamSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import org.apache.spark.streaming.dstream.ReceiverInputDStream
import org.apache.spark.streaming.util.ManualClock
import org.apache.spark.streaming.{TestSuiteBase, TestOutputStream, StreamingContext}
import org.apache.spark.streaming.flume.sink._
import org.apache.spark.util.Utils

class FlumePollingStreamSuite extends TestSuiteBase {

Expand All @@ -45,8 +46,37 @@ class FlumePollingStreamSuite extends TestSuiteBase {
val eventsPerBatch = 100
val totalEventsPerChannel = batchCount * eventsPerBatch
val channelCapacity = 5000
val maxAttempts = 5

test("flume polling test") {
testMultipleTimes(testFlumePolling)
}

test("flume polling test multiple hosts") {
testMultipleTimes(testFlumePollingMultipleHost)
}

/**
* Run the given test until no more java.net.BindException's are thrown.
* Do this only up to a certain attempt limit.
*/
private def testMultipleTimes(test: () => Unit): Unit = {
var testPassed = false
var attempt = 0
while (!testPassed && attempt < maxAttempts) {
try {
test()
testPassed = true
} catch {
case e: Exception if Utils.isBindCollision(e) =>
logWarning("Exception when running flume polling test: " + e)
attempt += 1
}
}
assert(testPassed, s"Test failed after $attempt attempts!")
}

private def testFlumePolling(): Unit = {
val testPort = getTestPort
// Set up the streaming context and input streams
val ssc = new StreamingContext(conf, batchDuration)
Expand Down Expand Up @@ -80,7 +110,7 @@ class FlumePollingStreamSuite extends TestSuiteBase {
channel.stop()
}

test("flume polling test multiple hosts") {
private def testFlumePollingMultipleHost(): Unit = {
val testPort = getTestPort
// Set up the streaming context and input streams
val ssc = new StreamingContext(conf, batchDuration)
Expand Down