[SPARK-20557] [SQL] Support JDBC data type Time with Time Zone #17835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76393 has finished for PR 17835 at commit
|
| @@ -230,7 +230,9 @@ object JdbcUtils extends Logging { | |||
| // scalastyle:on | |||
| } | |||
|
|
|||
| if (answer == null) throw new SQLException("Unsupported type " + sqlType) | |||
| if (answer == null) { | |||
| throw new SQLException("Unsupported type " + JDBCType.valueOf(sqlType).getName) | |||
There was a problem hiding this comment.
Hi, @gatorsmile .
Then, it seems that we need to consider IllegalArgumentException from JDBCType.valueOf then.
Can we do that here?
There was a problem hiding this comment.
Captured in line 236. Thanks!
There was a problem hiding this comment.
Ur, I thought JDBCType.valueOf(sqlType) might throw IllegalArgumentException with invalid sqlType.
There was a problem hiding this comment.
Oh, sorry. I saw an old code. Forget about that.
|
Test build #76512 has started for PR 17835 at commit |
|
retest this please |
gatorsmile
changed the title
|
+1 LGTM. |
|
Test build #76519 has finished for PR 17835 at commit
|
|
retest this please |
|
Test build #76526 has finished for PR 17835 at commit
|
|
Thanks! Merging to master. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Dec 12, 2017
…ialect ## What changes were proposed in this pull request? In the previous PRs, apache#17832 and apache#17835 , we convert `TIMESTAMP WITH TIME ZONE` and `TIME WITH TIME ZONE` to `TIMESTAMP` for all the JDBC sources. However, this conversion could be risky since it does not respect our SQL configuration `spark.sql.session.timeZone`. In addition, each vendor might have different semantics for these two types. For example, Postgres simply returns `TIMESTAMP` types for `TIMESTAMP WITH TIME ZONE`. For such supports, we should do it case by case. This PR reverts the general support of `TIMESTAMP WITH TIME ZONE` and `TIME WITH TIME ZONE` for JDBC sources, except ORACLE Dialect. When supporting the ORACLE's `TIMESTAMP WITH TIME ZONE`, we only support it when the JVM default timezone is the same as the user-specified configuration `spark.sql.session.timeZone` (whose default is the JVM default timezone). Now, we still treat `TIMESTAMP WITH TIME ZONE` as `TIMESTAMP` when fetching the values via the Oracle JDBC connector, whose client converts the timestamp values with time zone to the timestamp values using the local JVM default timezone (a test case is added to `OracleIntegrationSuite.scala` in this PR for showing the behavior). Thus, to avoid any future behavior change, we will not support it if JVM default timezone is different from `spark.sql.session.timeZone` No regression because the previous two PRs were just merged to be unreleased master branch. ## How was this patch tested? Added the test cases Author: gatorsmile <gatorsmile@gmail.com> Closes apache#19939 from gatorsmile/timezoneUpdate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to support JDBC data type TIME WITH TIME ZONE. It can be converted to TIMESTAMP
In addition, before this PR, for unsupported data types, we simply output the type number instead of the type name.
After this PR, the message is like
1.4.195which has the type fix for "TIMESTAMP WITH TIMEZONE". However, it is not fully supported. Thus, we capture the exception, but we still need it to partially test the support of "TIMESTAMP WITH TIMEZONE", because Docker tests are not regularly run.How was this patch tested?
Added test cases.