Skip to content

[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools #17695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools #17695

wants to merge 2 commits into from

Conversation

bllchmbrs
Copy link
Contributor

What changes were proposed in this pull request?

Simple documentation change to remove explicit vendor references.

How was this patch tested?

NA

Please review http://spark.apache.org/contributing.html before opening a pull request.

@bllchmbrs
Copy link
Contributor Author

This should be on hold until a JIRA resolution, I'd like to hear what others say.

@gatorsmile
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented Apr 20, 2017

Test build #75969 has finished for PR 17695 at commit 5692124.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen requested changes Apr 20, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per JIRA, this is

docs/configuration.md Outdated
@@ -2248,8 +2248,8 @@ should be included on Spark's classpath:
* `hdfs-site.xml`, which provides default behaviors for the HDFS client.
* `core-site.xml`, which sets the default filesystem name.

The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across hadoop versions, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadoop -> Hadoop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @anabranch

docs/configuration.md Outdated
The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across hadoop versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools create
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also won't matter either way, but is an example of an instance where naming a specific product is helpful information for users. There's no policy against this. But, it can be removed, sure, it's trivial either way.

@bllchmbrs
Copy link
Contributor Author

Thanks for the info @srowen - this should be better now.

@SparkQA
Copy link

SparkQA commented Apr 23, 2017

Test build #76086 has finished for PR 17695 at commit e74c2d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Apr 24, 2017
View reviewed changes
docs/configuration.md
@@ -2248,8 +2248,8 @@ should be included on Spark's classpath:
* `hdfs-site.xml`, which provides default behaviors for the HDFS client.
* `core-site.xml`, which sets the default filesystem name.

The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across Hadoop versions, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I guess one issue I've realized now is that it doesn't really vary across versions of Hadoop but could vary according to packaging and distribution. If you change it again, also consider fixing the existing "mechanisms" typo in line 2253

@srowen
Copy link
Member

srowen commented Apr 26, 2017

OK, merged it anyway to master/2.2

asfgit pushed a commit that referenced this pull request Apr 26, 2017
@srowen
[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools
a2f5ced 
## What changes were proposed in this pull request?

Simple documentation change to remove explicit vendor references.

## How was this patch tested?

NA

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: anabranch <bill@databricks.com>

Closes #17695 from anabranch/remove-vendor.

(cherry picked from commit 7a36525)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 7a36525 Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bllchmbrs @gatorsmile @SparkQA @srowen