[SPARK-19970][SQL][Follow-up] Table owner should be USER instead of PRINCIPAL in kerberized clusters #17311 #17405
Conversation
|
Test build #75134 has finished for PR 17405 at commit
|
|
|
||
| override def createTable(table: CatalogTable, ignoreIfExists: Boolean): Unit = withHiveState { | ||
| client.createTable(toHiveTable(table, Some(conf)), ignoreIfExists) | ||
| client.createTable(toHiveTable(table), ignoreIfExists) |
There was a problem hiding this comment.
This has different semantics because it'll always skip setting the owner.
There was a problem hiding this comment.
uh, I forgot to change it back... Thanks for catching it.
| /** Returns the configuration for the current session. */ | ||
| def conf: HiveConf = state.getConf | ||
|
|
||
| private val userName = state.getAuthenticator.getUserName |
There was a problem hiding this comment.
is this userName shared by all SparkSessions?
There was a problem hiding this comment.
All the SparkSessions share the same internal Hive SessionState. After we create it, the user name is set, if my understanding is not wrong, no matter which HiveAuthenticationProvider that users choose.
Previously, before merging the PR #17311, do we have the same issue?
|
Test build #75142 has finished for PR 17405 at commit
|
|
@gatorsmile . It looks good to me. Thank you for refactoring. |
|
thanks, merging to master! |
5 participants
What changes were proposed in this pull request?
This is a follow-up for the PR: #17311
sessionStateto get the user name, instead of callingSessionState.get()in the functiontoHiveTable.user namesinstead ofconfwhen callingtoHiveTable.How was this patch tested?
N/A