[SPARK-19899][ML] Replace featuresCol with itemsCol in ml.fpm.FPGrowth #17321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74684 has finished for PR 17321 at commit
|
MLnick
reviewed
Mar 17, 2017
| * Default: "items" | ||
| * @group param | ||
| */ | ||
| @Since("2.2.0") |
There was a problem hiding this comment.
We normally don't annotate in traits since later things may be overridden by concrete implementers. Although I do see a few places where it is done...
There was a problem hiding this comment.
FPGrowthParams has been annotated before so I decided to make it consistent. I can remove annotation here, but then we should probably follow through and remove the rest.
There was a problem hiding this comment.
I think it's OK to have it here. Only FPGrowth and FPGrowthModel will ever inherit from FPGrowthParams.
|
LGTM |
|
Thanks @jkbradley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces
featuresColParamwithitemsCol. See SPARK-19899.How was this patch tested?
Manual tests. Existing unit tests.