[SPARK-19824][Core] Standalone master JSON not showing cores for running applications by yongtang · Pull Request #17181 · apache/spark

yongtang · 2017-03-06T21:12:15Z

What changes were proposed in this pull request?

This fix tries to address the issue raised in SPARK-19824 where
the JSON API of the standalone master ("/json") does not show
the number of cores for a running (active) application, which is
available on the master UI.

The reason was that in master UI, coresGranted was used:
https://github.com/apache/spark/blob/v2.1.0/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala#L220
while in JSON API, the desc.maxCores was used. In case
there is no limit on maxCores, this filed will be missing on
JSON API. (Master UI show cores granted so the field is always available).

This fix address the discrepancy by changing JSON API to use
coredGranted so that UI and JSON API are consistent.

How was this patch tested?

The test was done manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

…ing applications This fix tries to address the issue raised in SPARK-19824 where the JSON API of the standalone master ("/json") does not show the number of cores for a running (active) application, which is available on the master UI. The reason was that in master UI, `coresGranted` was used: https://github.com/apache/spark/blob/v2.1.0/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala#L220 while in JSON API, the `desc.maxCores` was used. In case there is no limit on `maxCores`, this filed will be missing on JSON API. (Master UI show cores granted so the field is always available). This fix address the discrepancy by changing JSON API to use `coredGranted` so that UI and JSON API are consistent. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

nanop · 2017-03-06T21:28:54Z

core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala

    ("starttime" -> obj.startTime) ~
    ("id" -> obj.id) ~
    ("name" -> obj.desc.name) ~
-    ("cores" -> obj.desc.maxCores) ~


why not keep both?

@nanop this is to align with Master UI. I can update the PR to add additional field in the JSON API if confirmed from maintainers.

jiangxb1987 · 2017-05-25T00:37:40Z

I think the fix is correct, it would be great if you could add test cases to cover this in JsonProtocolSuite.
Also cc @gatorsmile @cloud-fan

cloud-fan · 2017-05-25T01:54:20Z

yea, also a screenshot about this in Spark UI will be great

gatorsmile · 2017-05-25T04:39:56Z

ok to test

gatorsmile · 2017-05-25T04:40:56Z

Could you please check whether there exists any other inconsistent value between the UI and JSON API? Thanks!

SparkQA · 2017-05-25T06:50:11Z

Test build #77335 has finished for PR 17181 at commit f8b5eaf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

jiangxb1987 · 2017-05-26T23:10:51Z

ping @yongtang

## What changes were proposed in this pull request? Fix any inconsistent part in JsonProtocol with the UI. This PR also contains the modifications in #17181 ## How was this patch tested? Updated JsonProtocolSuite. Before this change, localhost:8080/json shows: ``` { "url" : "spark://xingbos-MBP.local:7077", "workers" : [ { "id" : "worker-20170615172946-192.168.0.101-49450", "host" : "192.168.0.101", "port" : 49450, "webuiaddress" : "http://192.168.0.101:8081", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497519481722 }, { "id" : "worker-20170615172948-192.168.0.101-49452", "host" : "192.168.0.101", "port" : 49452, "webuiaddress" : "http://192.168.0.101:8082", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497519484160 }, { "id" : "worker-20170615172951-192.168.0.101-49469", "host" : "192.168.0.101", "port" : 49469, "webuiaddress" : "http://192.168.0.101:8083", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497519486905 } ], "cores" : 24, "coresused" : 24, "memory" : 46080, "memoryused" : 3072, "activeapps" : [ { "starttime" : 1497519426990, "id" : "app-20170615173706-0001", "name" : "Spark shell", "user" : "xingbojiang", "memoryperslave" : 1024, "submitdate" : "Thu Jun 15 17:37:06 CST 2017", "state" : "RUNNING", "duration" : 65362 } ], "completedapps" : [ { "starttime" : 1497519250893, "id" : "app-20170615173410-0000", "name" : "Spark shell", "user" : "xingbojiang", "memoryperslave" : 1024, "submitdate" : "Thu Jun 15 17:34:10 CST 2017", "state" : "FINISHED", "duration" : 116895 } ], "activedrivers" : [ ], "status" : "ALIVE" } ``` After the change: ``` { "url" : "spark://xingbos-MBP.local:7077", "workers" : [ { "id" : "worker-20170615175032-192.168.0.101-49951", "host" : "192.168.0.101", "port" : 49951, "webuiaddress" : "http://192.168.0.101:8081", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497520292900 }, { "id" : "worker-20170615175034-192.168.0.101-49953", "host" : "192.168.0.101", "port" : 49953, "webuiaddress" : "http://192.168.0.101:8082", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497520280301 }, { "id" : "worker-20170615175037-192.168.0.101-49955", "host" : "192.168.0.101", "port" : 49955, "webuiaddress" : "http://192.168.0.101:8083", "cores" : 8, "coresused" : 8, "coresfree" : 0, "memory" : 15360, "memoryused" : 1024, "memoryfree" : 14336, "state" : "ALIVE", "lastheartbeat" : 1497520282884 } ], "aliveworkers" : 3, "cores" : 24, "coresused" : 24, "memory" : 46080, "memoryused" : 3072, "activeapps" : [ { "id" : "app-20170615175122-0001", "starttime" : 1497520282115, "name" : "Spark shell", "cores" : 24, "user" : "xingbojiang", "memoryperslave" : 1024, "submitdate" : "Thu Jun 15 17:51:22 CST 2017", "state" : "RUNNING", "duration" : 10805 } ], "completedapps" : [ { "id" : "app-20170615175058-0000", "starttime" : 1497520258766, "name" : "Spark shell", "cores" : 24, "user" : "xingbojiang", "memoryperslave" : 1024, "submitdate" : "Thu Jun 15 17:50:58 CST 2017", "state" : "FINISHED", "duration" : 9876 } ], "activedrivers" : [ ], "completeddrivers" : [ ], "status" : "ALIVE" } ``` Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closes #18303 from jiangxb1987/json-protocol.

gatorsmile · 2017-06-27T06:46:18Z

We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks!

## What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017 I believe the author in apache#14807 removed his account. Closes apache#7075 Closes apache#8927 Closes apache#9202 Closes apache#9366 Closes apache#10861 Closes apache#11420 Closes apache#12356 Closes apache#13028 Closes apache#13506 Closes apache#14191 Closes apache#14198 Closes apache#14330 Closes apache#14807 Closes apache#15839 Closes apache#16225 Closes apache#16685 Closes apache#16692 Closes apache#16995 Closes apache#17181 Closes apache#17211 Closes apache#17235 Closes apache#17237 Closes apache#17248 Closes apache#17341 Closes apache#17708 Closes apache#17716 Closes apache#17721 Closes apache#17937 Added: Closes apache#14739 Closes apache#17139 Closes apache#17445 Closes apache#18042 Closes apache#18359 Added: Closes apache#16450 Closes apache#16525 Closes apache#17738 Added: Closes apache#16458 Closes apache#16508 Closes apache#17714 Added: Closes apache#17830 Closes apache#14742 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#18417 from HyukjinKwon/close-stale-pr.

nanop reviewed Mar 6, 2017

View reviewed changes

jiangxb1987 mentioned this pull request Jun 14, 2017

[SPARK-19824][Core] Update JsonProtocol to keep consistent with the UI #18303

Closed

HyukjinKwon mentioned this pull request Jun 25, 2017

[INFRA] Close stale PRs #18417

Closed

asfgit closed this in b32bd00 Jun 27, 2017

yongtang deleted the SPARK-19824 branch January 19, 2018 01:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-19824][Core] Standalone master JSON not showing cores for running applications#17181

[SPARK-19824][Core] Standalone master JSON not showing cores for running applications#17181
yongtang wants to merge 1 commit intoapache:masterfrom
yongtang:SPARK-19824

yongtang commented Mar 6, 2017

Uh oh!

nanop Mar 6, 2017

Uh oh!

yongtang Mar 6, 2017

Uh oh!

jiangxb1987 commented May 25, 2017 •

edited

Loading

Uh oh!

cloud-fan commented May 25, 2017

Uh oh!

gatorsmile commented May 25, 2017

Uh oh!

gatorsmile commented May 25, 2017 •

edited

Loading

Uh oh!

SparkQA commented May 25, 2017

Uh oh!

jiangxb1987 commented May 26, 2017

Uh oh!

gatorsmile commented Jun 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

yongtang commented Mar 6, 2017

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

nanop Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

yongtang Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

jiangxb1987 commented May 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloud-fan commented May 25, 2017

Uh oh!

gatorsmile commented May 25, 2017

Uh oh!

gatorsmile commented May 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SparkQA commented May 25, 2017

Uh oh!

jiangxb1987 commented May 26, 2017

Uh oh!

gatorsmile commented Jun 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jiangxb1987 commented May 25, 2017 •

edited

Loading

gatorsmile commented May 25, 2017 •

edited

Loading