[SPARK-19673][SQL] "ThriftServer default app name is changed wrong" #17010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Feb 21, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Oh I see. I think that makes sense, but am not an expert here.
Contributor
Author
|
Before spark1.4.x, the ThriftServer name is "SparkSQL:localhostname",while https://issues.apache.org/jira/browse/SPARK-8650 change the rule as a side effect. Then the ThriftServer show the class name of HiveThriftServer2, which is not appropriate. |
Member
|
ok to test |
Member
|
cc @watermen @yhuai @liancheng since this PR is related to #7030 |
|
Test build #73204 has finished for PR 17010 at commit
|
Contributor
Author
|
Execuse me, may this issue be merged and closed ? |
srowen
approved these changes
Feb 25, 2017
Member
|
Merged to master |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
## What changes were proposed in this pull request? In spark 1.x ,the name of ThriftServer is SparkSQL:localHostName. While the ThriftServer default name is changed to the className of HiveThfift2 , which is not appropriate. ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: lvdongr <lv.dongdong@zte.com.cn> Closes apache#17010 from lvdongr/ThriftserverName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In spark 1.x ,the name of ThriftServer is SparkSQL:localHostName. While the ThriftServer default name is changed to the className of HiveThfift2 , which is not appropriate.
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.