[SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld be filtered out by sqlContext.parquetFile
|
Can one of the admins verify this patch? |
| val children = fs.listStatus(path).filterNot( | ||
| status => (status.getPath.getName.charAt(0) == '.' || | ||
| status.getPath.getName == FileOutputCommitter.SUCCEEDED_FILE_NAME) | ||
| ) |
There was a problem hiding this comment.
I'd prefer to reformat these lines a bit:
val children = fs.listStatus(path).filterNot { status =>
val name = status.getPath.getName
name(0) == '.' || name == FileOutputCommitter.SUCCEEDED_FILE_NAME
}
|
LGTM except for minor styling issue. Thanks! |
|
done, thanks |
|
add to whitelist |
|
QA tests have started for PR 1691. This patch merges cleanly. |
|
QA results for PR 1691: |
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2014
…ld be filtered out by sqlContext.parquetFile Author: chutium <teng.qiu@gmail.com> Closes #1691 from chutium/SPARK-2700 and squashes the following commits: b76ae8c [chutium] [SPARK-2700] [SQL] fixed styling issue d75a8bd [chutium] [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile (cherry picked from commit b7c89a7) Signed-off-by: Michael Armbrust <michael@databricks.com>
|
Thanks! Merge into master and 1.1. (Test failures look unrelated) |
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
…ld be filtered out by sqlContext.parquetFile Author: chutium <teng.qiu@gmail.com> Closes apache#1691 from chutium/SPARK-2700 and squashes the following commits: b76ae8c [chutium] [SPARK-2700] [SQL] fixed styling issue d75a8bd [chutium] [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.