[SPARK-19549] Allow providing reason for stage/job cancelling #16887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
rxin
reviewed
Feb 10, 2017
| */ | ||
| def cancelJob(jobId: Int) { | ||
| dagScheduler.cancelJob(jobId) | ||
| def cancelJob(jobId: Int, reason: String = "") { |
Contributor
There was a problem hiding this comment.
actually you need to define a new function with two parameters and keep the old one to maintain binary compatibility for the public APIs.
rxin
reviewed
Feb 10, 2017
| * Cancel a job that is running or waiting in the queue. | ||
| */ | ||
| def cancelJob(jobId: Int): Unit = { | ||
| def cancelJob(jobId: Int, reason: String = ""): Unit = { |
Contributor
There was a problem hiding this comment.
internally can we use an Option rather than empty string?
Contributor
|
LGTM pending Jenkins. |
hvanhovell
reviewed
Feb 10, 2017
| def cancelJob(jobId: Int) { | ||
| dagScheduler.cancelJob(jobId) | ||
| def cancelJob(jobId: Int, reason: String): Unit = { | ||
| dagScheduler.cancelJob(jobId, Some(reason)) |
Contributor
There was a problem hiding this comment.
Please use Option(reason), Some(reason) will happily wrap a null.
|
Test build #72712 has finished for PR 16887 at commit
|
|
Test build #72716 has finished for PR 16887 at commit
|
|
Test build #72717 has finished for PR 16887 at commit
|
Contributor
|
Merging in master! |
|
Test build #72713 has finished for PR 16887 at commit
|
Contributor
|
retest this please |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? This change add an optional argument to `SparkContext.cancelStage()` and `SparkContext.cancelJob()` functions, which allows the caller to provide exact reason for the cancellation. ## How was this patch tested? Adds unit test. Author: Ala Luszczak <ala@databricks.com> Closes apache#16887 from ala/cancel.
liancheng
pushed a commit
to liancheng/spark
that referenced
this pull request
Mar 17, 2017
This change add an optional argument to `SparkContext.cancelStage()` and `SparkContext.cancelJob()` functions, which allows the caller to provide exact reason for the cancellation. Adds unit test. Author: Ala Luszczak <ala@databricks.com> Closes apache#16887 from ala/cancel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change add an optional argument to
SparkContext.cancelStage()andSparkContext.cancelJob()functions, which allows the caller to provide exact reason for the cancellation.How was this patch tested?
Adds unit test.