Skip to content

[SPARK-19396] [DOC] JDBC Options are Case In-sensitive #16734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

The case are not sensitive in JDBC options, after the PR #15884 is merged to Spark 2.1.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @srowen @cloud-fan @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Jan 29, 2017

Test build #72130 has finished for PR 16734 at commit 33022e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -1135,7 +1135,7 @@ Tables from the remote database can be loaded as a DataFrame or Spark SQL tempor
the Data Sources API. Users can specify the JDBC connection properties in the data source options.
<code>user</code> and <code>password</code> are normally provided as connection properties for
logging into the data sources. In addition to the connection properties, Spark also supports
the following case-sensitive options:
the following case-insensitive options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@gatorsmile gatorsmile force-pushed the fixDocCaseInsensitive branch from 1474e97 to 33022e3 Compare January 30, 2017 02:28
@SparkQA
Copy link

SparkQA commented Jan 30, 2017

Test build #72141 has finished for PR 16734 at commit 33022e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 30, 2017

Test build #72140 has finished for PR 16734 at commit 1474e97.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jan 30, 2017
### What changes were proposed in this pull request?
The case are not sensitive in JDBC options, after the PR #15884 is merged to Spark 2.1.

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #16734 from gatorsmile/fixDocCaseInsensitive.

(cherry picked from commit c0eda7e)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@gatorsmile
Copy link
Member Author

Thanks! Merging to master.

@asfgit asfgit closed this in c0eda7e Jan 30, 2017
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
### What changes were proposed in this pull request?
The case are not sensitive in JDBC options, after the PR apache#15884 is merged to Spark 2.1.

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes apache#16734 from gatorsmile/fixDocCaseInsensitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants