[SPARK-18750][yarn] Avoid using "mapValues" when allocating containers. #16667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That method is prone to stack overflows when the input map is really large; instead, use plain "map". Also includes a unit tests that was tested and caused stack overflows without the fix.
|
Test build #71751 has finished for PR 16667 at commit
|
|
Argh, api not available in old hadoop... fix coming. |
|
Test build #71756 has finished for PR 16667 at commit
|
srowen
approved these changes
Jan 22, 2017
tgravescs
reviewed
Jan 23, 2017
| import org.apache.hadoop.fs.CommonConfigurationKeysPublic | ||
| import org.apache.hadoop.net.DNSToSwitchMapping | ||
| import org.apache.hadoop.yarn.api.records._ | ||
| import org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest |
There was a problem hiding this comment.
not used that I see, remove
| yarnConf, resource) | ||
|
|
||
| val totalTasks = 32 * 1024 | ||
| val totalContainers = totalTasks / 16 |
There was a problem hiding this comment.
any particular reason for the 16 here? I assume its just random selected that shows the issue but perhaps add in a comment.
| val count = containers.size / hosts.size / 2 | ||
|
|
||
| val hostToContainerMap = new HashMap[String, Set[ContainerId]]() | ||
| hosts.keys.take(hosts.size / 2).zipWithIndex.foreach { case (host, i) => |
There was a problem hiding this comment.
similar wouldn't hurt to have small description here for someone looking at it later
|
Test build #71867 has finished for PR 16667 at commit
|
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2017
That method is prone to stack overflows when the input map is really large; instead, use plain "map". Also includes a unit test that was tested and caused stack overflows without the fix. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #16667 from vanzin/SPARK-18750. (cherry picked from commit 76db394) Signed-off-by: Tom Graves <tgraves@yahoo-inc.com>
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2017
That method is prone to stack overflows when the input map is really large; instead, use plain "map". Also includes a unit test that was tested and caused stack overflows without the fix. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #16667 from vanzin/SPARK-18750. (cherry picked from commit 76db394) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
That method is prone to stack overflows when the input map is really large; instead, use plain "map". Also includes a unit test that was tested and caused stack overflows without the fix. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#16667 from vanzin/SPARK-18750.
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Feb 7, 2017
…ainers. apache#16667 without adding LocalityPlacementStrategySuite.scala
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
That method is prone to stack overflows when the input map is really large; instead, use plain "map". Also includes a unit test that was tested and caused stack overflows without the fix. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#16667 from vanzin/SPARK-18750.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That method is prone to stack overflows when the input map is really
large; instead, use plain "map". Also includes a unit test that was
tested and caused stack overflows without the fix.