-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-19219][SQL] Fix Parquet log output defaults #16580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-19219][SQL] Fix Parquet log output defaults #16580
Conversation
Link to this JIRA issue: https://issues.apache.org/jira/browse/SPARK-19219 |
So the change here is really to turn up the log level for non-test code, not just the test code? it seems possibly reasonable but are there important warnings this would suppress for users? |
That's possible. We could narrow the scope a bit and instead just set |
Test build #71345 has finished for PR 16580 at commit
|
@nicklavers yeah narrowing the scope seems more conservative and desirable. Do the test configs need to be changed similarly to match your newer proposal? |
…_default_parquet_log_level
c7df9ac
to
cb80164
Compare
I don't see why not |
Test build #71459 has finished for PR 16580 at commit
|
Test build #71462 has finished for PR 16580 at commit
|
Test build #71460 has finished for PR 16580 at commit
|
Merged to master |
## What changes were proposed in this pull request? Changing the default parquet logging levels to reflect the changes made in PR [apache#15538](apache#15538), in order to prevent the flood of log messages by default. ## How was this patch tested? Default log output when reading from parquet 1.6 files was compared with and without this change. The change eliminates the extraneous logging and makes the output readable. Author: Nick Lavers <nick.lavers@videoamp.com> Closes apache#16580 from nicklavers/spark-19219-set_default_parquet_log_level.
## What changes were proposed in this pull request? Changing the default parquet logging levels to reflect the changes made in PR [apache#15538](apache#15538), in order to prevent the flood of log messages by default. ## How was this patch tested? Default log output when reading from parquet 1.6 files was compared with and without this change. The change eliminates the extraneous logging and makes the output readable. Author: Nick Lavers <nick.lavers@videoamp.com> Closes apache#16580 from nicklavers/spark-19219-set_default_parquet_log_level.
What changes were proposed in this pull request?
Changing the default parquet logging levels to reflect the changes made in PR #15538, in order to prevent the flood of log messages by default.
How was this patch tested?
Default log output when reading from parquet 1.6 files was compared with and without this change. The change eliminates the extraneous logging and makes the output readable.