[SPARK-19140][SS]Allow update mode for non-aggregation streaming queries #16520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #71096 has finished for PR 16520 at commit
|
|
LGTM! ultra nit: |
brkyvz
reviewed
Jan 10, 2017
| @@ -58,7 +62,9 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) { | |||
| * the sink | |||
| * - `complete`: all the rows in the streaming DataFrame/Dataset will be written to the sink | |||
| * every time these is some updates | |||
| * | |||
| * - `update`: only the rows that were updated in the streaming DataFrame/Dataset will | |||
There was a problem hiding this comment.
Could you also please update pyspark docs?
|
Also could you please update pyspark docs? |
|
Test build #71157 has finished for PR 16520 at commit
|
brkyvz
reviewed
Jan 10, 2017
| @@ -665,6 +665,9 @@ def outputMode(self, outputMode): | |||
| the sink | |||
| * `complete`:All the rows in the streaming DataFrame/Dataset will be written to the sink | |||
| every time these is some updates | |||
| * `update`:only the rows that were updated in the streaming DataFrame/Dataset will be | |||
| written to the sink every time there are some updates. If the query doesn't contain | |||
| aggregations, it will be equivalent to the `append` mode. | |||
There was a problem hiding this comment.
nit: please remove the before append.
brkyvz
reviewed
Jan 10, 2017
| every time these is some updates | ||
| * `update`:only the rows that were updated in the streaming DataFrame/Dataset will be | ||
| written to the sink every time there are some updates. If the query doesn't contain | ||
| aggregations, it will be equivalent to the `append` mode. |
brkyvz
reviewed
Jan 10, 2017
| @@ -57,7 +57,8 @@ public static OutputMode Complete() { | |||
|
|
|||
| /** | |||
| * OutputMode in which only the rows that were updated in the streaming DataFrame/Dataset will | |||
| * be written to the sink every time there are some updates. | |||
| * be written to the sink every time there are some updates. If the query doesn't contain | |||
| * aggregations, it will be equivalent to the `Append` mode. | |||
brkyvz
reviewed
Jan 10, 2017
| * written to the sink every time these is some updates. This output mode can only be used in | ||
| * queries that contain aggregations. | ||
| * written to the sink every time these is some updates. If the query doesn't contain | ||
| * aggregations, it will be equivalent to the `Append` mode. |
|
Left a nit (occurring multiple times), otherwise LGTM! |
|
thanks LGTM! |
|
Test build #71159 has finished for PR 16520 at commit
|
|
Test build #71168 has finished for PR 16520 at commit
|
|
Thanks. Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Jan 11, 2017
…ries ## What changes were proposed in this pull request? This PR allow update mode for non-aggregation streaming queries. It will be same as the append mode if a query has no aggregations. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes #16520 from zsxwing/update-without-agg. (cherry picked from commit bc6c56e) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ries ## What changes were proposed in this pull request? This PR allow update mode for non-aggregation streaming queries. It will be same as the append mode if a query has no aggregations. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#16520 from zsxwing/update-without-agg.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…ries ## What changes were proposed in this pull request? This PR allow update mode for non-aggregation streaming queries. It will be same as the append mode if a query has no aggregations. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#16520 from zsxwing/update-without-agg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allow update mode for non-aggregation streaming queries. It will be same as the append mode if a query has no aggregations.
How was this patch tested?
Jenkins