Skip to content

[SPARK-18662] Move resource managers to separate directory #16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/sparktestsupport/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def __hash__(self):
name="yarn",
dependencies=[],
source_file_regexes=[
"yarn/",
"resource-managers/yarn/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update L477 (and probably a similar change in the mesos entry).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzin If I understand correctly, the sbt test goals can stay the same?
I can see them defined the same way for other modules such as sketch (as sketch/test), but it is nested under common/.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Nevermind, I thought those were file paths like these. So fine the way they are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzin also rebased after recent changes to HEAD. Is this okay to merge?

"common/network-yarn/",
],
build_profile_flags=["-Pyarn"],
Expand All @@ -485,7 +485,7 @@ def __hash__(self):
mesos = Module(
name="mesos",
dependencies=[],
source_file_regexes=["mesos/"],
source_file_regexes=["resource-managers/mesos/"],
build_profile_flags=["-Pmesos"],
sbt_test_goals=["mesos/test"]
)
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2580,15 +2580,15 @@
<profile>
<id>yarn</id>
<modules>
<module>yarn</module>
<module>resource-managers/yarn</module>
<module>common/network-yarn</module>
</modules>
</profile>

<profile>
<id>mesos</id>
<modules>
<module>mesos</module>
<module>resource-managers/mesos</module>
</modules>
</profile>

Expand Down
2 changes: 1 addition & 1 deletion mesos/pom.xml → resource-managers/mesos/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.11</artifactId>
<version>2.2.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>spark-mesos_2.11</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion yarn/pom.xml → resource-managers/yarn/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.11</artifactId>
<version>2.2.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>spark-yarn_2.11</artifactId>
Expand Down