Skip to content

[SPARK-18189] [SQL] [Followup] Move test from ReplSuite to prevent java.lang.ClassCircularityError #15774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

seyfe
Copy link
Contributor

@seyfe seyfe commented Nov 4, 2016

What changes were proposed in this pull request?

Move the test which is causing java.lang.ClassCircularityError from ReplSuite to DatasetSuite.

How was this patch tested?

build/mvn -DskipTests -Phadoop-2.3 -Pyarn -Phive -Phive-thriftserver -Pkinesis-asl -Pmesos clean package
build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite test

@rxin
Copy link
Contributor

rxin commented Nov 4, 2016

LGTM pending Jenkins.

@rxin
Copy link
Contributor

rxin commented Nov 4, 2016

Is this not an issue with the master branch and branch-2.1?

@seyfe
Copy link
Contributor Author

seyfe commented Nov 4, 2016

Hi @rxin ,

According to #15706 it was failing the maven tests for 2.0.2 RC2.

I checked and see that this is actually causing failures for master and branch-2.1 as well. sbt builds are good.

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.4/2216/

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.1-test-maven-hadoop-2.7/15/

@seyfe seyfe changed the title [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test from ReplSuite to prevent java.lang.ClassCircularityError [SPARK-18189] [SQL] [Followup] Move test from ReplSuite to prevent java.lang.ClassCircularityError Nov 4, 2016
@rxin
Copy link
Contributor

rxin commented Nov 4, 2016

So master/branch-2.1 is failing too right? I should merge this into master, branch-2.1, and branch-2.0?

@seyfe
Copy link
Contributor Author

seyfe commented Nov 4, 2016

Yes @rxin, please merge into all 3 branches. master/branch-2.1/branch-2.0

@SparkQA
Copy link

SparkQA commented Nov 5, 2016

Test build #3415 has finished for PR 15774 at commit bd513b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Nov 5, 2016

Thanks - merging in branch-2.0. There is a conflict with master/branch-2.1. I will fix those.

asfgit pushed a commit that referenced this pull request Nov 5, 2016
….lang.ClassCircularityError

## What changes were proposed in this pull request?
Move the test which is causing java.lang.ClassCircularityError from ReplSuite to DatasetSuite.

## How was this patch tested?
> build/mvn -DskipTests -Phadoop-2.3 -Pyarn -Phive -Phive-thriftserver -Pkinesis-asl -Pmesos clean package
> build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite test

Author: Ergin Seyfe <eseyfe@fb.com>

Closes #15774 from seyfe/fix_replsuite_test_error_branch2.0.
asfgit pushed a commit that referenced this pull request Nov 5, 2016
…va.lang.ClassCircularityError

closes #15774

(cherry picked from commit 0f7c9e8)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 0f7c9e8 Nov 5, 2016
@srowen
Copy link
Member

srowen commented Nov 5, 2016

+1 thanks @seyfe . That's a weird error and I think this is the right way to play it right now.

uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
@seyfe seyfe deleted the fix_replsuite_test_error_branch2.0 branch February 27, 2017 19:36
fishcus added a commit to fishcus/spark that referenced this pull request Nov 4, 2019
fishcus added a commit to Kyligence/spark that referenced this pull request Nov 11, 2019
eventd added a commit to eventd/spark that referenced this pull request Dec 2, 2019
eventd added a commit to Kyligence/spark that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants