Skip to content

[SPARK-18216][SQL] Make Column.expr public #15724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Nov 2, 2016

What changes were proposed in this pull request?

Column.expr is private[sql], but it's an actually really useful field to have for debugging. We should open it up, similar to how we use QueryExecution.

How was this patch tested?

N/A - this is a simple visibility change.

@marmbrus
Copy link
Contributor

marmbrus commented Nov 2, 2016

LGTM

@ssimeonov
Copy link
Contributor

👍

@SparkQA
Copy link

SparkQA commented Nov 2, 2016

Test build #67937 has finished for PR 15724 at commit bbf1d10.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Column(val expr: Expression) extends Logging

@rxin
Copy link
Contributor Author

rxin commented Nov 2, 2016

Thanks - merging in master.

@asfgit asfgit closed this in ad4832a Nov 2, 2016
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
Column.expr is private[sql], but it's an actually really useful field to have for debugging. We should open it up, similar to how we use QueryExecution.

## How was this patch tested?
N/A - this is a simple visibility change.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#15724 from rxin/SPARK-18216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants