Skip to content

[SPARK-18192] Support all file formats in structured streaming #15711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Nov 1, 2016

What changes were proposed in this pull request?

This patch adds support for all file formats in structured streaming sinks. This is actually a very small change thanks to all the previous refactoring done using the new internal commit protocol API.

How was this patch tested?

Updated FileStreamSinkSuite to add test cases for json, text, and parquet.

@SparkQA
Copy link

SparkQA commented Nov 1, 2016

Test build #67875 has finished for PR 15711 at commit 3d6e424.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 1, 2016

Test build #67876 has finished for PR 15711 at commit 4a1707e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin rxin changed the title [SPARK-18192] Support all file formats in structured streaming - WIP [SPARK-18192] Support all file formats in structured streaming Nov 2, 2016
@marmbrus
Copy link
Contributor

marmbrus commented Nov 2, 2016

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Nov 2, 2016

Test build #3391 has finished for PR 15711 at commit fd35316.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2016

Test build #67943 has finished for PR 15711 at commit fd35316.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Nov 2, 2016

@marmbrus I ended up adding test cases since they were trivial to add (and an existing test case was asserting that text would not be supported).

@SparkQA
Copy link

SparkQA commented Nov 2, 2016

Test build #3392 has finished for PR 15711 at commit 29071bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2016

Test build #67952 has finished for PR 15711 at commit 29071bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Nov 2, 2016

Merging in master/branch-2.1

@asfgit asfgit closed this in a36653c Nov 2, 2016
asfgit pushed a commit that referenced this pull request Nov 2, 2016
## What changes were proposed in this pull request?
This patch adds support for all file formats in structured streaming sinks. This is actually a very small change thanks to all the previous refactoring done using the new internal commit protocol API.

## How was this patch tested?
Updated FileStreamSinkSuite to add test cases for json, text, and parquet.

Author: Reynold Xin <rxin@databricks.com>

Closes #15711 from rxin/SPARK-18192.

(cherry picked from commit a36653c)
Signed-off-by: Reynold Xin <rxin@databricks.com>
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
This patch adds support for all file formats in structured streaming sinks. This is actually a very small change thanks to all the previous refactoring done using the new internal commit protocol API.

## How was this patch tested?
Updated FileStreamSinkSuite to add test cases for json, text, and parquet.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#15711 from rxin/SPARK-18192.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants