[SPARK-18042][SQL] OutputWriter should expose file path written #15580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and @ericl |
cloud-fan
reviewed
Oct 21, 2016
| new SerializableConfiguration(conf) | ||
| } | ||
|
|
||
| /** | ||
| * Returns a [[OutputWriter]] that writes data to the give path without using | ||
| * [[OutputCommitter]]. | ||
| */ | ||
| override def newWriter(path: String): OutputWriter = new OutputWriter { | ||
| override def newWriter(path1: String): OutputWriter = new OutputWriter { |
There was a problem hiding this comment.
how about _path? path1 looks weird...
There was a problem hiding this comment.
or maybe we can create a class for this OutputWriter here.
cloud-fan
reviewed
Oct 21, 2016
| new Path(stagingDir, fileNamePrefix + extension) | ||
| } | ||
| new ParquetOutputFormat[InternalRow]() { | ||
| override def getDefaultWorkFile(context: TaskAttemptContext, extension: String): Path = { |
There was a problem hiding this comment.
now we never use the context and extension parameters?
There was a problem hiding this comment.
I will add some documentation in my next pull request.
|
Test build #67330 has finished for PR 15580 at commit
|
|
cc @HyukjinKwon |
ericl
reviewed
Oct 21, 2016
| * The path of the file to be written out. This path should include the staging directory and | ||
| * the file name prefix passed into the associated createOutputWriter function. | ||
| */ | ||
| def path: String |
|
Test build #67344 has finished for PR 15580 at commit
|
|
lgtm |
|
Thanks - I'm going to merge this. I will address the doc and naming comment in the next pr in this series. |
HyukjinKwon
reviewed
Oct 22, 2016
| @@ -35,7 +35,7 @@ private[parquet] class ParquetOptions( | |||
| * Compression codec to use. By default use the value specified in SQLConf. | |||
| * Acceptable values are defined in [[shortParquetCompressionCodecNames]]. | |||
| */ | |||
| val compressionCodec: String = { | |||
| val compressionCodecClassName: String = { | |||
There was a problem hiding this comment.
@rxin This is a super minor but there are the same options to potentially rename in OrcOptions, JsonOptions, CSVOptions and TextFileFormat - TextFileFormat.scala#L71.
Also, I'd like to note, just in case, that the value in this is actually not the class name (it's something like SNAPPY and LZO) in case of ParquetOptions and OrcOptions whereas text-based ones are actual class names.
|
@HyukjinKwon sure. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? This patch adds a new "path" method on OutputWriter that returns the path of the file written by the OutputWriter. This is part of the necessary work to consolidate structured streaming and batch write paths. The batch write path has a nice feature that each data source can define the extension of the files, and allow Spark to specify the staging directory and the prefix for the files. However, in the streaming path we need to collect the list of files written, and there is no interface right now to do that. ## How was this patch tested? N/A - there is no behavior change and this should be covered by existing tests. Author: Reynold Xin <rxin@databricks.com> Closes apache#15580 from rxin/SPARK-18042.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This patch adds a new "path" method on OutputWriter that returns the path of the file written by the OutputWriter. This is part of the necessary work to consolidate structured streaming and batch write paths. The batch write path has a nice feature that each data source can define the extension of the files, and allow Spark to specify the staging directory and the prefix for the files. However, in the streaming path we need to collect the list of files written, and there is no interface right now to do that. ## How was this patch tested? N/A - there is no behavior change and this should be covered by existing tests. Author: Reynold Xin <rxin@databricks.com> Closes apache#15580 from rxin/SPARK-18042.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds a new "path" method on OutputWriter that returns the path of the file written by the OutputWriter. This is part of the necessary work to consolidate structured streaming and batch write paths.
The batch write path has a nice feature that each data source can define the extension of the files, and allow Spark to specify the staging directory and the prefix for the files. However, in the streaming path we need to collect the list of files written, and there is no interface right now to do that.
How was this patch tested?
N/A - there is no behavior change and this should be covered by existing tests.