Skip to content

Backport SPARK-17599 and SPARK-17569 to Spark 2.0 branch #15202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Sep 22, 2016

What changes were proposed in this pull request?

This Backports PR #15153 and PR #15122 to Spark 2.0 branch for Structured Streaming.
It is structured a bit differently because similar code paths already existed in the 2.0 branch. The unit test makes sure that both behaviors don't break.

@brkyvz
Copy link
Contributor Author

brkyvz commented Sep 22, 2016

@zsxwing and @cloud-fan

@rxin
Copy link
Contributor

rxin commented Sep 22, 2016

Please separate these as two pull requests.

@brkyvz
Copy link
Contributor Author

brkyvz commented Sep 22, 2016

@rxin The only change that was needed was:
https://github.com/apache/spark/pull/15202/files#diff-e82a44dc550d2a0a92e44d1ec2ecabccR137
Which was equivalent to the two master branch changes

@SparkQA
Copy link

SparkQA commented Sep 22, 2016

Test build #65790 has finished for PR 15202 at commit 6d3a750.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Sep 22, 2016

@rxin this one just added the unit test of #15153 into branch 2.0 + #15122. Do you still insist on separating them?

@rxin
Copy link
Contributor

rxin commented Sep 23, 2016

OK that's fine. Merging in. Thanks.

asfgit pushed a commit that referenced this pull request Sep 23, 2016
## What changes were proposed in this pull request?

This Backports PR #15153 and PR #15122 to Spark 2.0 branch for Structured Streaming.
It is structured a bit differently because similar code paths already existed in the 2.0 branch. The unit test makes sure that both behaviors don't break.

Author: Burak Yavuz <brkyvz@gmail.com>

Closes #15202 from brkyvz/backports-to-streaming.
@rxin
Copy link
Contributor

rxin commented Sep 23, 2016

@brkyvz can you close this now?

@brkyvz brkyvz closed this Sep 23, 2016
@brkyvz
Copy link
Contributor Author

brkyvz commented Sep 23, 2016

Thanks @rxin

@brkyvz brkyvz deleted the backports-to-streaming branch February 3, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants