[SPARKR][DOC] regexp_extract should doc that it returns empty string when match fails #14934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #64835 has finished for PR 14934 at commit
|
| @@ -2876,7 +2876,8 @@ setMethod("randn", signature(seed = "numeric"), | |||
|
|
|||
| #' regexp_extract | |||
| #' | |||
| #' Extract a specific(idx) group identified by a java regex, from the specified string column. | |||
| #' Extract a specific \code{idx} group identified by a Java regex, from the specified string column. | |||
There was a problem hiding this comment.
Minor comment: It looks like idx was removed in the comment change in #14525 -- I'm not sure if it matters, but we could either keep it consistent with the Scala/Python doc or keep the idx if you think it helps.
There was a problem hiding this comment.
I noticed that - I thought @param idx a group index isn't super descriptive on what it is
|
LGTM. Merging into master, branch-2.0 |
asfgit
pushed a commit
that referenced
this pull request
Sep 2, 2016
…when match fails ## What changes were proposed in this pull request? Doc change - see https://issues.apache.org/jira/browse/SPARK-16324 ## How was this patch tested? manual check Author: Felix Cheung <felixcheung_m@hotmail.com> Closes #14934 from felixcheung/regexpextractdoc. (cherry picked from commit 419eefd) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Doc change - see https://issues.apache.org/jira/browse/SPARK-16324
How was this patch tested?
manual check