[SPARK-17027][ML] Avoid integer overflow in PolynomialExpansion.getPolySize #14614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63649 has finished for PR 14614 at commit
|
|
LGTM |
|
@zero323 actually would you mind adding a quick test in |
|
Test build #63728 has finished for PR 14614 at commit
|
|
Test build #63729 has finished for PR 14614 at commit
|
|
@srowen By all means. Here you are. |
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2016
…lySize ## What changes were proposed in this pull request? Replaces custom choose function with o.a.commons.math3.CombinatoricsUtils.binomialCoefficient ## How was this patch tested? Spark unit tests Author: zero323 <zero323@users.noreply.github.com> Closes #14614 from zero323/SPARK-17027. (cherry picked from commit 0ebf7c1) Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2016
…lySize Replaces custom choose function with o.a.commons.math3.CombinatoricsUtils.binomialCoefficient Spark unit tests Author: zero323 <zero323@users.noreply.github.com> Closes #14614 from zero323/SPARK-17027. (cherry picked from commit 0ebf7c1) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0 |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Aug 15, 2016
…lySize Replaces custom choose function with o.a.commons.math3.CombinatoricsUtils.binomialCoefficient Spark unit tests Author: zero323 <zero323@users.noreply.github.com> Closes apache#14614 from zero323/SPARK-17027. (cherry picked from commit 0ebf7c1) Signed-off-by: Sean Owen <sowen@cloudera.com> (cherry picked from commit b54a586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces custom choose function with o.a.commons.math3.CombinatoricsUtils.binomialCoefficient
How was this patch tested?
Spark unit tests