[SPARK-16939][SQL] Fix build error by using Tuple1 explicitly in StringFunctionsSuite
#14526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ringFunctionsSuite
|
Ah, shoot, that would be my fault. I am not sure why it would only fail for 1.6? let me also look into it. Thanks for the catch. |
|
Oh, thank you, @srowen ! |
|
Until today, I also guessed that master branch does not handle this. |
| @@ -95,7 +95,7 @@ class StringFunctionsSuite extends QueryTest with SharedSQLContext { | |||
| } | |||
|
|
|||
| test("non-matching optional group") { | |||
| val df = Seq("aaaac").toDF("s") | |||
| val df = Seq(Tuple1("aaaac")).toDF("s") | |||
There was a problem hiding this comment.
OK, I guess that Scala 2.11 has an implicit conversion that Scala 2.10 does not that would make this conversion automatically, hence the PR builder succeeded. We could also just add a dummy column in the example, but I suppose this is the best way to ensure that the fix works in 1.6, and also makes the test a little more robust. LGTM, thanks.
There was a problem hiding this comment.
Thank you, @srowen .
|
Test build #63328 has finished for PR 14526 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2016
…ringFunctionsSuite ## What changes were proposed in this pull request? This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this. https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console ```scala [error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String] [error] val df = Seq("aaaac").toDF("s") [error] ^ ``` ## How was this patch tested? After passing Jenkins, run compilation test on branch 1.6. ``` build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes #14526 from dongjoon-hyun/SPARK-16939. (cherry picked from commit a16983c) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0/1.6 |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2016
…ringFunctionsSuite ## What changes were proposed in this pull request? This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this. https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console ```scala [error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String] [error] val df = Seq("aaaac").toDF("s") [error] ^ ``` ## How was this patch tested? After passing Jenkins, run compilation test on branch 1.6. ``` build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes #14526 from dongjoon-hyun/SPARK-16939. (cherry picked from commit a16983c) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Thank you for review and merging, @srowen ! |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Aug 8, 2016
…ringFunctionsSuite ## What changes were proposed in this pull request? This PR aims to fix a build error on branch 1.6 at apache@8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (apache#14525) about this. https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console ```scala [error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String] [error] val df = Seq("aaaac").toDF("s") [error] ^ ``` ## How was this patch tested? After passing Jenkins, run compilation test on branch 1.6. ``` build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#14526 from dongjoon-hyun/SPARK-16939. (cherry picked from commit a16983c) Signed-off-by: Sean Owen <sowen@cloudera.com> (cherry picked from commit a3b06ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this.
https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console
How was this patch tested?
After passing Jenkins, run compilation test on branch 1.6.