[SPARK-16884] Move DataSourceScanExec out of ExistingRDD.scala file #14487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +360,7 @@ private[sql] object DataSourceStrategy extends Strategy with Logging { | |||
| val markedFilters = for (filter <- pushedFilters) yield { | |||
| if (handledFilters.contains(filter)) s"*$filter" else s"$filter" | |||
| } | |||
| pairs += (PUSHED_FILTERS -> markedFilters.mkString("[", ", ", "]")) | |||
| pairs += ("PushedFilters" -> markedFilters.mkString("[", ", ", "]")) | |||
There was a problem hiding this comment.
I also got rid of the string constant for this. It doesn't seem to be required for correctness, and we also use raw strings for other metadata keys / metrics so it seemed inconsistent.
|
Test build #63196 has finished for PR 14487 at commit
|
|
LGTM, merging into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This moves DataSourceScanExec out so it's more discoverable, and now that it doesn't necessarily depend on an existing RDD. cc @davies
How was this patch tested?
Existing tests.