[SPARK-16875][SQL] Add args checking for DataSet randomSplit and sample #14478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I wonder if we should even disallow a 0% sample, but, OK as-is. |
|
Test build #63168 has finished for PR 14478 at commit
|
|
Ah, let's do this for the RDD API too eh? |
|
@srowen Right. I just add those checking for RDD. |
|
Test build #63210 has finished for PR 14478 at commit
|
|
Merged to master / 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Aug 4, 2016
## What changes were proposed in this pull request? Add the missing args-checking for randomSplit and sample ## How was this patch tested? unit tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes #14478 from zhengruifeng/fix_randomSplit. (cherry picked from commit be8ea4b) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the missing args-checking for randomSplit and sample
How was this patch tested?
unit tests