[SPARK-16863][ML] ProbabilisticClassifier.fit check threshoulds' length #14470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63146 has finished for PR 14470 at commit
|
| @@ -84,6 +84,13 @@ class DecisionTreeClassifier @Since("1.4.0") ( | |||
| val categoricalFeatures: Map[Int, Int] = | |||
| MetadataUtils.getCategoricalFeatures(dataset.schema($(featuresCol))) | |||
| val numClasses: Int = getNumClasses(dataset) | |||
|
|
|||
| if (isDefined(thresholds)) { | |||
| require($(thresholds).length == numClasses, this.getClass.getSimpleName + | |||
There was a problem hiding this comment.
Nit, but why not use string interpolation for the class name bit?
There was a problem hiding this comment.
Because ProbabilisticClassificationModel.transform first check like this, so I just follow this style.
There was a problem hiding this comment.
Hm, OK. I suppose I'm indifferent then.
zhengruifeng
force-pushed
the
classifier_check_setThreshoulds_length
branch
from
2c6929d to
df5af72
Compare
|
Test build #63213 has finished for PR 14470 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 4, 2016
## What changes were proposed in this pull request? Add threshoulds' length checking for Classifiers which extends ProbabilisticClassifier ## How was this patch tested? unit tests and manual tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes #14470 from zhengruifeng/classifier_check_setThreshoulds_length. (cherry picked from commit 0e2e5d7) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add threshoulds' length checking for Classifiers which extends ProbabilisticClassifier
How was this patch tested?
unit tests and manual tests