Skip to content

[SPARK-16858] [SQL] [TEST] Removal of TestHiveSharedState #14463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Aug 2, 2016

What changes were proposed in this pull request?

This PR is to remove TestHiveSharedState.

Also, this is also associated with the Hive refractoring for removing HiveSharedState.

How was this patch tested?

The existing test cases

@rxin
Copy link
Contributor

rxin commented Aug 2, 2016

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Aug 2, 2016

Test build #63130 has finished for PR 14463 at commit 30e2f6e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

gatorsmile commented Aug 2, 2016

The test failure is caused by the fact that SharedState is not being shared between different sessions. Since we define our own TestHiveSparkSession in TestHive (i.e., not directly using SparkSession), we still need extra logics to sharing/passing the SharedState between different sessions.

Now, we can remove the TestHiveSharedState, but we still need to explicitly have a HiveSharedState.

@gatorsmile
Copy link
Member Author

Updated the PR description.

@SparkQA
Copy link

SparkQA commented Aug 2, 2016

Test build #63134 has finished for PR 14463 at commit dc98d5d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

@rxin @yhuai The code is ready for review. Thanks!

@rxin
Copy link
Contributor

rxin commented Aug 2, 2016

Merging in master.

@asfgit asfgit closed this in b73a570 Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants