[SPARK-16628][SQL] Don't convert Orc Metastore tables to datasource tables if metastore schema does not match schema stored in the files #14282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tastore schema does not match schema stored in the Orc/Parquet files.
|
Test build #62590 has finished for PR 14282 at commit
|
|
Shouldn't the proper fix be addressing the issue for conversion, rather than disabling conversion? |
|
Agreed. This is just the option 1 in the JIRA. The option 2 needs to change more codes. I will look into it. |
|
This can be closed now because we don't infer schema from Orc files when converting Hive Orc tables to data source tables anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We will convert Metastore Orc tables (represented by
MetastoreRelation) to datasource tables (represented byHadoopFsRelation) ifspark.sql.hive.convertMetastoreOrcis enabled for better performance.However, due to a Hive issue, an Orc table created by Hive does not store column name correctly in the Orc files. For these Orc tables, we can't do the conversion.
This PR tries to compare the inferred schema of Orc files with Metastore schema. If they don't match, we skip the conversion and continue to use
MetastoreRelation.As Parquet will have similar conversion, this PR does the same checking for it too.
How was this patch tested?
Jenkins tests.