Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases #14173

Closed
wants to merge 8 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use x instead of col in window functions
  • Loading branch information
shivaram committed Jul 13, 2016
commit 62be1cbe9464acb5dbcb62f2c54fe906488ded6a
8 changes: 4 additions & 4 deletions R/pkg/R/window.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ setMethod("window.partitionBy",
windowSpec(
callJStatic("org.apache.spark.sql.expressions.Window",
"partitionBy",
col,
x,
list(...)))
})

Expand All @@ -52,7 +52,7 @@ setMethod("window.partitionBy",
setMethod("window.partitionBy",
signature(x = "Column"),
function(x, ...) {
jcols <- lapply(list(col, ...), function(c) {
jcols <- lapply(list(x, ...), function(c) {
c@jc
})
windowSpec(
Expand Down Expand Up @@ -84,7 +84,7 @@ setMethod("window.orderBy",
windowSpec(
callJStatic("org.apache.spark.sql.expressions.Window",
"orderBy",
col,
x,
list(...)))
})

Expand All @@ -96,7 +96,7 @@ setMethod("window.orderBy",
setMethod("window.orderBy",
signature(x = "Column"),
function(x, ...) {
jcols <- lapply(list(col, ...), function(c) {
jcols <- lapply(list(x, ...), function(c) {
c@jc
})
windowSpec(
Expand Down