[SPARK-16488] Fix codegen variable namespace collision in pmod and partitionBy #14144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxin |
| @@ -498,34 +498,35 @@ case class Pmod(left: Expression, right: Expression) extends BinaryArithmetic wi | |||
|
|
|||
| override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { | |||
| nullSafeCodeGen(ctx, ev, (eval1, eval2) => { | |||
| val r = ctx.freshName("r") | |||
There was a problem hiding this comment.
while you are at this, can you pick a better name? "r" is not very informative.
|
LGTM pending Jenkins. |
|
Test build #62129 has finished for PR 14144 at commit
|
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2016
…rtitionBy This patch fixes a variable namespace collision bug in pmod and partitionBy Regression test for one possible occurrence. A more general fix in `ExpressionEvalHelper.checkEvaluation` will be in a subsequent PR. Author: Sameer Agarwal <sameer@databricks.com> Closes #14144 from sameeragarwal/codegen-bug. (cherry picked from commit 9cc74f9) Signed-off-by: Reynold Xin <rxin@databricks.com>
|
Test build #62135 has finished for PR 14144 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2016
…rtitionBy This patch fixes a variable namespace collision bug in pmod and partitionBy Regression test for one possible occurrence. A more general fix in `ExpressionEvalHelper.checkEvaluation` will be in a subsequent PR. Author: Sameer Agarwal <sameer@databricks.com> Closes #14144 from sameeragarwal/codegen-bug. (cherry picked from commit 9cc74f9) Signed-off-by: Reynold Xin <rxin@databricks.com> (cherry picked from commit 6892614) Signed-off-by: Reynold Xin <rxin@databricks.com>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jul 13, 2016
…rtitionBy This patch fixes a variable namespace collision bug in pmod and partitionBy Regression test for one possible occurrence. A more general fix in `ExpressionEvalHelper.checkEvaluation` will be in a subsequent PR. Author: Sameer Agarwal <sameer@databricks.com> Closes apache#14144 from sameeragarwal/codegen-bug. (cherry picked from commit 9cc74f9) Signed-off-by: Reynold Xin <rxin@databricks.com> (cherry picked from commit 6892614) Signed-off-by: Reynold Xin <rxin@databricks.com> (cherry picked from commit d1c992f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes a variable namespace collision bug in pmod and partitionBy
How was this patch tested?
Regression test for one possible occurrence. A more general fix in
ExpressionEvalHelper.checkEvaluationwill be in a subsequent PR.