Skip to content

[SPARK-15467][build] update janino version to 3.0.0 #14127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Jul 10, 2016

What changes were proposed in this pull request?

This PR updates version of Janino compiler from 2.7.8 to 3.0.0. This version fixes an Janino issue that fixes an issue, which throws Java exception, in Spark.

How was this patch tested?

Manually tested using a program in the JIRA entry

@SparkQA
Copy link

SparkQA commented Jul 10, 2016

Test build #62060 has finished for PR 14127 at commit ce31dda.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 10, 2016

You'll need to update the deps files. More importantly what are the potential incompatible changes that could affect Spark?

@kiszk
Copy link
Member Author

kiszk commented Jul 10, 2016

Here is a change log of Janino. Updates from 2.7.8 are the followings:

  • JANINO-186: Code size error message should include method name: Also report when the constant pool size limit is exceeded.
  • JANINO-185: Improve logging: Replaced good ol' if (DEBUG) System.err.println(...) with `java.util.logging{.
  • org.codehaus.janino.ScriptEvaluator now supports the concept of "local methods".
  • Implemented annotations (declarations and uses)
  • Implemented enums (uses only)
  • Added (limited) support for method type parameters.
  • Added support for annotations on package declarations.
  • Added an "architectural overview" in the JAVADOC.

The first item is a fix for the reported issue. Other items seem to be to add new features. While I think that there is no potential incompatible changes according to changelog, I would like to see the result of Jenkins at first.

@SparkQA
Copy link

SparkQA commented Jul 10, 2016

Test build #62063 has finished for PR 14127 at commit 2c702c5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jul 11, 2016

Thanks - merging in master.

@asfgit asfgit closed this in f12a38b Jul 11, 2016
@srowen
Copy link
Member

srowen commented Jul 11, 2016

Sounds like a small set of changes; not sure why it was a major version change. shrug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Janino throws runtime excetion for a method with more than 254 of operand stack height
4 participants