[SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver for scala 2.10 #14108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JoshRosen @rxin |
| @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then | |||
| -Phive-thriftserver deploy | |||
| ./dev/change-scala-version.sh 2.10 | |||
| $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ | |||
| -DskipTests $PUBLISH_PROFILES clean deploy | |||
| -DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy | |||
There was a problem hiding this comment.
Shouldn't this be in PUBLISH_PROFILES?
There was a problem hiding this comment.
+1. I think the only reason that it wasn't there to begin with was because Scala 2.11 didn't always support the Hive ThriftServer. Let's move it there and also update line 258.
There was a problem hiding this comment.
ah right. Let me move it to there.
|
@srowen Does it look good? |
|
LGTM |
|
Thanks. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 8, 2016
…r scala 2.10 ## What changes were proposed in this pull request? This PR adds hive-thriftserver profile to scala 2.10 build created by release-build.sh. Author: Yin Huai <yhuai@databricks.com> Closes #14108 from yhuai/SPARK-16453. (cherry picked from commit 60ba436) Signed-off-by: Yin Huai <yhuai@databricks.com>
|
Test build #61998 has finished for PR 14108 at commit
|
|
Test build #61999 has finished for PR 14108 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds hive-thriftserver profile to scala 2.10 build created by release-build.sh.