[MINOR][Streaming][Docs] Minor changes on kinesis integration #14097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #61937 has finished for PR 14097 at commit
|
|
hi @srowen do you mind have a look at this one? very minor changes... thank you :) |
|
Seems reasonable. |
|
maybe I should also cc @tdas , he is on the streaming part |
| @@ -9,7 +9,7 @@ Here we explain how to configure Spark Streaming to receive data from Kinesis. | |||
|
|
|||
| #### Configuring Kinesis | |||
|
|
|||
| A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards per the following | |||
| A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards following | |||
There was a problem hiding this comment.
The sentence was correct before but now is ungrammatical
There was a problem hiding this comment.
excuse me for my English...
kinesis stream can be set (...) per the guide?
There was a problem hiding this comment.
Yes, but that's only removing "following" and I don't think that's an improvement.
There was a problem hiding this comment.
I see... I'll revert it back to original
|
Test build #62061 has finished for PR 14097 at commit
|
|
LGTM. Merging to master and 2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2016
## What changes were proposed in this pull request? Some minor changes for documentation page "Spark Streaming + Kinesis Integration". Moved "streaming-kinesis-arch.png" before the bullet list, not in between the bullets. ## How was this patch tested? Tested manually, on my local machine. Author: Xin Ren <iamshrek@126.com> Closes #14097 from keypointt/kinesisDoc. (cherry picked from commit 05d7151) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some minor changes for documentation page "Spark Streaming + Kinesis Integration".
Moved "streaming-kinesis-arch.png" before the bullet list, not in between the bullets.
How was this patch tested?
Tested manually, on my local machine.