[SPARK-16313][SQL] Spark should not silently drop exceptions in file listing #13987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Test build #61521 has finished for PR 13987 at commit
|
| cachedLeafFiles | ||
| } | ||
|
|
||
| override protected def leafDirToChildrenFiles: Map[Path, Array[FileStatus]] = { | ||
| if (cachedLeafDirToChildrenFiles eq null) { | ||
| refresh() |
There was a problem hiding this comment.
There is a side effect. refresh() reset the cachedPartitionSpec to null, which may clear already-inferred partition information.
override def refresh(): Unit = {
val files = listLeafFiles(paths)
cachedLeafFiles =
new mutable.LinkedHashMap[Path, FileStatus]() ++= files.map(f => f.getPath -> f)
cachedLeafDirToChildrenFiles = files.toArray.groupBy(_.getPath.getParent)
cachedPartitionSpec = null
}
|
Test build #61526 has finished for PR 13987 at commit
|
|
@yhuai this is the 3rd attempt -- in this one I changed it so we would ignore FileNotFoundException if a flag is set. |
|
Test build #61528 has finished for PR 13987 at commit
|
|
Test build #61529 has finished for PR 13987 at commit
|
|
Test build #61531 has finished for PR 13987 at commit
|
|
Test build #3154 has finished for PR 13987 at commit
|
|
Test build #61558 has finished for PR 13987 at commit
|
|
Test build #61571 has finished for PR 13987 at commit
|
|
Test build #61573 has finished for PR 13987 at commit
|
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 30, 2016
…listing ## What changes were proposed in this pull request? Spark silently drops exceptions during file listing. This is a very bad behavior because it can mask legitimate errors and the resulting plan will silently have 0 rows. This patch changes it to not silently drop the errors. ## How was this patch tested? Manually verified. Author: Reynold Xin <rxin@databricks.com> Closes #13987 from rxin/SPARK-16313. (cherry picked from commit 3d75a5b) Signed-off-by: Reynold Xin <rxin@databricks.com>
|
Test build #3156 has finished for PR 13987 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2016
…ons in file listing ## What changes were proposed in this pull request? Spark silently drops exceptions during file listing. This is a very bad behavior because it can mask legitimate errors and the resulting plan will silently have 0 rows. This patch changes it to not silently drop the errors. After making partition discovery not silently drop exceptions, HiveMetastoreCatalog can trigger partition discovery on empty tables, which cause FileNotFoundExceptions (these Exceptions were dropped by partition discovery silently). To address this issue, this PR introduces two **hacks** to workaround the issues. These two hacks try to avoid of triggering partition discovery on empty tables in HiveMetastoreCatalog. ## How was this patch tested? Manually tested. **Note: This is a backport of #13987 Author: Yin Huai <yhuai@databricks.com> Closes #14139 from yhuai/SPARK-16313-branch-1.6.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jul 15, 2016
…ons in file listing ## What changes were proposed in this pull request? Spark silently drops exceptions during file listing. This is a very bad behavior because it can mask legitimate errors and the resulting plan will silently have 0 rows. This patch changes it to not silently drop the errors. After making partition discovery not silently drop exceptions, HiveMetastoreCatalog can trigger partition discovery on empty tables, which cause FileNotFoundExceptions (these Exceptions were dropped by partition discovery silently). To address this issue, this PR introduces two **hacks** to workaround the issues. These two hacks try to avoid of triggering partition discovery on empty tables in HiveMetastoreCatalog. ## How was this patch tested? Manually tested. **Note: This is a backport of apache#13987 Author: Yin Huai <yhuai@databricks.com> Closes apache#14139 from yhuai/SPARK-16313-branch-1.6. (cherry picked from commit 6ea7d4b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark silently drops exceptions during file listing. This is a very bad behavior because it can mask legitimate errors and the resulting plan will silently have 0 rows. This patch changes it to not silently drop the errors.
How was this patch tested?
Manually verified.