[SPARK-15543][SQL] Rename DefaultSources to make them more self-describing #13311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,7 +107,7 @@ private[libsvm] class LibSVMOutputWriter( | |||
| * @see [[https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/ LIBSVM datasets]] | |||
| */ | |||
| @Since("1.6.0") | |||
| class DefaultSource extends FileFormat with DataSourceRegister { | |||
| class LibSVMFileFormat extends FileFormat with DataSourceRegister { | |||
There was a problem hiding this comment.
Can we add this to backwardCompatibilityMap just to be safe?
There was a problem hiding this comment.
it won't be type safe though.
|
Test build #59308 has finished for PR 13311 at commit
|
|
LGTM |
|
Test build #59310 has finished for PR 13311 at commit
|
|
Test build #59316 has finished for PR 13311 at commit
|
|
Test build #59318 has finished for PR 13311 at commit
|
|
Test build #59327 has finished for PR 13311 at commit
|
|
Test build #59326 has finished for PR 13311 at commit
|
|
Test build #59343 has finished for PR 13311 at commit
|
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
…ibing ## What changes were proposed in this pull request? This patch renames various DefaultSources to make their names more self-describing. The choice of "DefaultSource" was from the days when we did not have a good way to specify short names. They are now named: - LibSVMFileFormat - CSVFileFormat - JdbcRelationProvider - JsonFileFormat - ParquetFileFormat - TextFileFormat Backward compatibility is maintained through aliasing. ## How was this patch tested? Updated relevant test cases too. Author: Reynold Xin <rxin@databricks.com> Closes #13311 from rxin/SPARK-15543. (cherry picked from commit 361ebc2) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch renames various DefaultSources to make their names more self-describing. The choice of "DefaultSource" was from the days when we did not have a good way to specify short names.
They are now named:
Backward compatibility is maintained through aliasing.
How was this patch tested?
Updated relevant test cases too.