Skip to content

[SPARK-14893][SQL] Re-enable HiveSparkSubmitSuite SPARK-8489 test after HiveContext is removed #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dilipbiswal
Copy link
Contributor

What changes were proposed in this pull request?

Enable the test that was disabled when HiveContext was removed.

How was this patch tested?

Made sure the enabled test passes with the new jar.

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57855 has finished for PR 12924 at commit bc5af46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

cc @andrewor14

@andrewor14
Copy link
Contributor

@dilipbiswal thanks for fixing this! There's actually one more change that needs to be made in regression-test-SPARK-8489/Main.scala, since we're removing SparkSession.withHiveSupport. In particular, I would replace these lines (L36):

    val sc = new SparkContext("local", "testing")
    val sparkSession = SparkSession.withHiveSupport(sc)
    // This line should not throw scala.reflect.internal.MissingRequirementError.
    // See SPARK-8470 for more detail.
    val df = sparkSession.createDataFrame(Seq(MyCoolClass("1", "2", "3")))

with

    val spark = SparkSession.builder
      .master("local")
      .appName("testing")
      .enableHiveSupport()
      .getOrCreate()
    // This line should not throw scala.reflect.internal.MissingRequirementError.
    // See SPARK-8470 for more detail.
    val df = spark.createDataFrame(Seq(MyCoolClass("1", "2", "3")))

@dilipbiswal
Copy link
Contributor Author

@andrewor14 Sure Andrew. I will change it.

@andrewor14
Copy link
Contributor

Thanks, LGTM

@andrewor14
Copy link
Contributor

Merging into master 2.0.

asfgit pushed a commit that referenced this pull request May 5, 2016
…er HiveContext is removed

## What changes were proposed in this pull request?

Enable the test that was disabled when HiveContext was removed.

## How was this patch tested?

Made sure the enabled test passes with the new jar.

Author: Dilip Biswal <dbiswal@us.ibm.com>

Closes #12924 from dilipbiswal/spark-14893.

(cherry picked from commit 02c07e8)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 02c07e8 May 5, 2016
@dilipbiswal
Copy link
Contributor Author

@andrewor14 Thank you Andrew !!

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57921 has finished for PR 12924 at commit f9f80e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants