[SPARK-14449][SQL] SparkContext should use SparkListenerInterface #12227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55175 has finished for PR 12227 at commit
|
|
Test build #55235 has finished for PR 12227 at commit
|
|
/cc @rxin |
|
Merging in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
SparkFirehoseListenerimplementations are broken since we expect listeners to extendSparkListener, while the fire hose only extendsSparkListenerInterface. This changes the addListener function and the config based injection to use the interface instead.The existing tests in SparkListenerSuite are improved such that they would have caught this.
Follow-up to #12142