-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-14317] [SQL] Cleanup hash join #12102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #54674 has finished for PR 12102 at commit
|
Test build #54683 has finished for PR 12102 at commit
|
Join w long codegen=true 275 / 352 76.2 13.1 19.4X | ||
*/ | ||
|
||
runBenchmark("Join w long duplicated", N) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does long duplicated mean? do you mean non-unique key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Test build #54795 has finished for PR 12102 at commit
|
Test build #54796 has finished for PR 12102 at commit
|
LGTM |
Conflicts: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
Merging this into master, thanks! |
Test build #54863 has finished for PR 12102 at commit
|
Test build #54864 has finished for PR 12102 at commit
|
What changes were proposed in this pull request?
This PR did a few cleanup on HashedRelation and HashJoin:
How was this patch tested?
Existing tests.