Skip to content

[SPARK-14284][ML] KMeansSummary deprecating size; adding clusterSizes #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

shallys
Copy link
Contributor

@shallys shallys commented Mar 31, 2016

What changes were proposed in this pull request?

KMeansSummary class : deprecated size and added clusterSizes

@yanboliang
Copy link
Contributor

@shallys We can rename size to clusterSizes directly, because Spark 2.0 has not been released so we will not make any break change. Meanwhile, you should also change the call in SparkRWrapper.

ping @jkbradley @mengxr Could you add @shallys to whitelist?

@jkbradley
Copy link
Member

add to whitelist

@SparkQA
Copy link

SparkQA commented Mar 31, 2016

Test build #2717 has finished for PR 12084 at commit ccdfc1c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shallys
Copy link
Contributor Author

shallys commented Mar 31, 2016

@yanboliang I just made the changes as you suggested. Please take a look.

@SparkQA
Copy link

SparkQA commented Mar 31, 2016

Test build #2718 has finished for PR 12084 at commit 332aa16.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor

@shallys Because #12039 has been merged, could you update your PR to resolve the conflicts?

@shallys
Copy link
Contributor Author

shallys commented Apr 1, 2016

@yanboliang Updated the PR. Please take a look.

@jkbradley
Copy link
Member

LGTM
I'll test once before merging.

@SparkQA
Copy link

SparkQA commented Apr 4, 2016

Test build #2742 has finished for PR 12084 at commit 5edb176.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

@shallys Could you please remove the "WIP" tag from the PR title?

@shallys shallys changed the title [SPARK-14284][ML][WIP] KMeansSummary deprecating size; adding clusterSizes [SPARK-14284][ML] KMeansSummary deprecating size; adding clusterSizes Apr 5, 2016
@shallys
Copy link
Contributor Author

shallys commented Apr 5, 2016

@jkbradley Removed the WIP tag.

@jkbradley
Copy link
Member

LGTM
Merging with master
Thanks!

@asfgit asfgit closed this in d356901 Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants