[SPARK-14253][SQL] Refactor HiveFunctionRegistry for temporary functions #12051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2016 16:13
This allows the DDL commands (when we implement them later) to use this to create a FunctionBuilder when calling SessionCatalog methods. This is needed for temporary functions.
|
Test build #54474 has finished for PR 12051 at commit
|
|
Test build #54476 has finished for PR 12051 at commit
|
| */ | ||
| override def makeFunctionBuilder(funcName: String, funcClassName: String): FunctionBuilder = { | ||
| makeFunctionBuilder(funcName, Utils.classForName(funcClassName)) | ||
| } |
There was a problem hiding this comment.
Yay! It's great to avoid of letting Hive load the classes.
|
Test build #54479 has finished for PR 12051 at commit
|
|
LGTM, I can rebase #12036 against current change. |
|
Closing this in favor of #12036. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a prerequisite to SPARK-14123, which implements DDLs related to functions using
SessionCatalog. In order to supportCREATE TEMPORARY FUNCTIONwe need a way to make aFunctionBuilderfrom the function class name. This patch exposes an interface to do so.How was this patch tested?
Jenkins.