[Spark-13784][ML][WIP] Model export/import for spark.ml: RandomForests #12023
Conversation
|
@yanboliang @jkbradley Please help review the code. |
GayathriMurali
changed the title
|
ok to test |
| @@ -136,7 +144,8 @@ object RandomForestClassifier { | |||
| * [[http://en.wikipedia.org/wiki/Random_forest Random Forest]] model for classification. | |||
| * It supports both binary and multiclass labels, as well as both continuous and categorical | |||
| * features. | |||
| * @param _trees Decision trees in the ensemble. | |||
| * | |||
There was a problem hiding this comment.
Update your IntelliJ settings: Editor -> Code Style -> Scala -> ScalaDoc tab -> uncheck "Use scaladoc indent for leading asterisk."
You will probably need to manually correct these indentation changes for this PR, though.
|
I made an initial pass with high-level comments. It will be important to reuse more code. I'll stay tuned for updates. Thanks! |
|
add to whitelist |
|
Test build #2708 has finished for PR 12023 at commit
|
|
@GayathriMurali Will you be able to update this soon? If not, I'd be happy to help out. |
|
@jkbradley I should be able to update this by tonight. Would that work? |
|
Yes, that sounds fine. Thanks! |
|
@jkbradley I am sorry, I am afraid I will not be able to complete tonight. Can you please help me with reusing SplitData/build code from DecisionTrees in RandomForests? I am not sure how to reuse case class defined within an object in another object. |
|
Sure, I'll send a PR to update this PR. |
|
@GayathriMurali This turns out to be messier than I would have expected because of the fact that the RF Estimators and Models do not share the same Params. I'd like to take over this PR if that's OK. I'll use your commits too, so you'll be an author on it. I can send a PR soon. Would you mind helping to review the PR once I send it? Thanks a lot for your understanding. |
|
@jkbradley I was just about to ping you regarding this. I would definitely love to help out. I was out at Strata all week and couldn't get to this. Please let me know if you need anything else from me. |
|
@GayathriMurali Thanks a lot. I just opened [https://github.com//pull/12118] |
Please help review the code. I have the WIP included to make sure the changes look correct.
What changes were proposed in this pull request?
Model export/import for spark.ml RandomForests