[SPARK-14038][SQL] enable native view by default #11860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yhuai @liancheng |
|
Test build #53675 has finished for PR 11860 at commit
|
| } | ||
|
|
||
| val viewSchema = { | ||
| val viewText = new SQLBuilder(logicalPlan, sqlContext).toSQL |
There was a problem hiding this comment.
How about catching exceptions thrown from toSQL and suggest the user to turn off native view and retry?
|
LGTM except for two minor comments. |
|
Test build #53679 has finished for PR 11860 at commit
|
|
closing in favor of a safer version: #11872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As we have completed the
SQLBuilder, we can safely use it to support native view.This PR enables native view by default, and removes the old branch that implement native view by just wrapping the view string.
How was this patch tested?
existing tests.