[SPARK-13897][SQL] RelationalGroupedDataset and KeyValueGroupedDataset #11841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liancheng and @sameeragarwal |
|
Test build #53606 has finished for PR 11841 at commit
|
| @@ -315,6 +315,7 @@ object MimaExcludes { | |||
| ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.DataFrame"), | |||
| ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.DataFrame$"), | |||
| ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.LegacyFunctions"), | |||
| ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.GroupedDataset"), | |||
There was a problem hiding this comment.
Don't we need to handle GroupedData here?
|
LGTM except for one MiMA check question. |
|
Test build #53607 has finished for PR 11841 at commit
|
|
retest this please |
|
Test build #53617 has finished for PR 11841 at commit
|
|
Thanks - merging in master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Previously, Dataset.groupBy returns a GroupedData, and Dataset.groupByKey returns a GroupedDataset. The naming is very similar, and unfortunately does not convey the real differences between the two. Assume we are grouping by some keys (K). groupByKey is a key-value style group by, in which the schema of the returned dataset is a tuple of just two fields: key and value. groupBy, on the other hand, is a relational style group by, in which the schema of the returned dataset is flattened and contain |K| + |V| fields. This pull request also removes the experimental tag from RelationalGroupedDataset. It has been with DataFrame since 1.3, and we have enough confidence now to stabilize it. ## How was this patch tested? This is a rename to improve API understandability. Should be covered by all existing tests. Author: Reynold Xin <rxin@databricks.com> Closes apache#11841 from rxin/SPARK-13897.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, Dataset.groupBy returns a GroupedData, and Dataset.groupByKey returns a GroupedDataset. The naming is very similar, and unfortunately does not convey the real differences between the two.
Assume we are grouping by some keys (K). groupByKey is a key-value style group by, in which the schema of the returned dataset is a tuple of just two fields: key and value. groupBy, on the other hand, is a relational style group by, in which the schema of the returned dataset is flattened and contain |K| + |V| fields.
This pull request also removes the experimental tag from RelationalGroupedDataset. It has been with DataFrame since 1.3, and we have enough confidence now to stabilize it.
How was this patch tested?
This is a rename to improve API understandability. Should be covered by all existing tests.