[SPARK-14000][SQL] case class with a tuple field can't work in Dataset #11816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +110,12 @@ case class GetStructField(child: Expression, ordinal: Int, name: Option[String] | |||
|
|
|||
| override def dataType: DataType = childSchema(ordinal).dataType | |||
| override def nullable: Boolean = child.nullable || childSchema(ordinal).nullable | |||
| override def toString: String = s"$child.${name.getOrElse(childSchema(ordinal).name)}" | |||
|
|
|||
| override def toString: String = { | |||
There was a problem hiding this comment.
kind of unrelated change, toString should be able to run even this expression is unresolved.
|
Test build #53519 has finished for PR 11816 at commit
|
|
thanks - looks good to me (but i don't know this code well enough). |
|
cc @marmbrus |
|
Test build #53522 has finished for PR 11816 at commit
|
|
LGTM, merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? When we validate an encoder, we may call `dataType` on unresolved expressions. This PR fix the validation so that we will resolve attributes first. ## How was this patch tested? a new test in `DatasetSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes apache#11816 from cloud-fan/encoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we validate an encoder, we may call
dataTypeon unresolved expressions. This PR fix the validation so that we will resolve attributes first.How was this patch tested?
a new test in
DatasetSuite